Skip to content

Drop deprecated syslog options from default smb.conf

Andreas Hasenack requested to merge ahasenack/samba:drop-deprecated-syslog-options into master

This replaces the deprecated syslog only and syslog global options with the logging statement. I believe the behaviour remains the same after this change, and I adapted the comment that surrounds it.

Without this change, a default install has testparm(1) issue this annoying warning:

# testparm /etc/samba/smb.conf 
Load smb config files from /etc/samba/smb.conf
rlimit_max: increasing rlimit_max (1024) to minimum Windows limit (16384)
WARNING: The "syslog" option is deprecated
Processing section "[printers]"
Processing section "[print$]"
Loaded services file OK.
Server role: ROLE_STANDALONE

Press enter to see a dump of your service definitions

If syslog only is uncommented, it also triggers a warning:

# testparm /etc/samba/smb.conf 
Load smb config files from /etc/samba/smb.conf
rlimit_max: increasing rlimit_max (1024) to minimum Windows limit (16384)
WARNING: The "syslog" option is deprecated
WARNING: The "syslog only" option is deprecated
Processing section "[printers]"
Processing section "[print$]"
Loaded services file OK.
Server role: ROLE_STANDALONE

Press enter to see a dump of your service definitions

There is no handling for upgrade cases as the deprecated options still work just fine.

Merge request reports