Squid4 dep8 fixes
Hi, here are some DEP8 fixes that should make the tests pass. Currently they are failing in Debian CI at https://ci.debian.net/packages/s/squid/testing/amd64/.
Here is the log of a good run with these fixes applied, using the current master branch plus the fixes from this MR: http://people.ubuntu.com/~ahasenack/dep8-debian-squid-4.2-1-unreleased/
Please let me know what your preferences are regarding commit messages, d/changelog updates, etc.
The lack of ssl-cert is what is causing the current failure in ci.debian.net. In Ubuntu, ssl-cert is a dependency of the squid package. For Debian I chose to add it as a test dependency only, because I figured this would be a less controversial change. I might revisit suggesting that delta to Debian at some other time.
The apparmor test could use some work I suppose, because for some reason apparmor_parser doesn't fail when given a file that does not exist:
# apparmor_parser --verbose /does/not/exist; echo $?
File /does/not/exist not found, skipping...
0I fixed the profile name, but it still doesn't give me confidence in that test, since it was passing before when given a profile that didn't exist. Something to revisit.