- Dec 16, 2024
-
-
Simon McVittie authored
-
Simon McVittie authored
This reverts commit cfdcfd2b.
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
Update to upstream version '1.16.0' with Debian dir ded3cf4175d06a8bb55fc70de79e8ce43fbfc787
-
Simon McVittie authored
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie (Collabora) authored
configure_file() returns a file object, which was not intended to be a valid parameter for format() (even though in practice it works the way we wanted it to), causing newer Meson versions to report deprecation warnings. If the version of Meson is new enough, we can use the full_path() method. Otherwise, we'll have to re-compute the output filename. Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 872ce4d29a4c34b1ae8bb5d4e02fdc7a600a3075)
-
Simon McVittie (Collabora) authored
Meson accepts either booleans or strings as defaults for a boolean option, but recommends booleans, and raises deprecation warnings for strings. Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit dc56afed594c63f3b29d68af33397072a300c310)
-
- Dec 13, 2024
-
-
Simon McVittie (Collabora) authored
I don't think we use this for anything any more, because all build targets run in some more specific container; but just in case it's used, we should select the current stable release of Debian and not a previous, EOL version. Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 431c78b5fbd96b930a50e177e1f0d39e730aadae)
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
This fixes a deprecation warning that compatibility with CMake < 3.10 will be removed from a future version of CMake. Resolves: dbus/dbus#533 Signed-off-by:
Ralf Habacker <ralf.habacker@freenet.de> (cherry picked from commit ca39b3799ea73fb9876e306c7d87b0856207fee1)
-
To achieve comparable results with Meson, the test environment should provide the same set of environment variables when used in the source code or the test environment. Resolves: dbus/dbus#541 Signed-off-by:
Ralf Habacker <ralf.habacker@freenet.de> (cherry picked from commit 8a78585514dcf498f3282515d8cef5e5b9a51324)
-
- Dec 11, 2024
-
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
This build enables options that are likely to be insecure, and certainly reduce performance and robustness. It should not be considered to be covered by security support.
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
Update to upstream version '1.15.92' with Debian dir e954800c37aedfefcc85451c53742ce923ffa848
-
Simon McVittie authored
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie (Collabora) authored
dbus!501 intentionally not mentioned here, it's a purely internal change. Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 648f4c2c372aac207e711429886e84810ef0c387)
-
Simon McVittie (Collabora) authored
We no longer have an Autotools build system, but Meson sets the same environment variables that Autotools used to set. CMake does not, yet, but ideally should. Resolves: https://gitlab.freedesktop.org/dbus/dbus/-/issues/538 Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 229e48f549dfb1af891545fd978974dd462777da)
-
init_connections_unlocked() is called when connecting to any of the well-known buses, and it initializes all of the well-known addresses: session, system and starter. This means that a failure here causes failure to connect to any one of the well-known buses, even if the failure is actually only relevant to a different well-known bus. As such, it should only fail on genuinely fatal errors, for example an out-of-memory condition. It calls init_session_address() and indirectly _dbus_lookup_session_address(), which therefore need to have similar behaviour. Previously, _dbus_lookup_session_address() would fail with a fatal error whenever the macOS session bus was not correctly set up, but that breaks the ability to connect to the system bus on macOS, even though the system bus is not directly related to the session bus. Instead, we should report a missing session bus as "not supported", reserving an unsuccessful result for fatal situations like out-of-memory. This brings _dbus_lookup_session_address_launchd() into line with the error behaviour of _dbus_lookup_user_bus(). Closes: #510 (cherry picked from commit 827e952793b6ddda1bd84da3ae9f46204661cd6e)
-
- Dec 10, 2024
-
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com>
-
Simon McVittie (Collabora) authored
Similar to #256, NSS plugins might open file descriptors the first time they look up a system group, and leave them open. To avoid detecting this as a leak, do one group lookup (which we expect to fail) before starting testing, so that the fd is already open the first time we call _dbus_check_fdleaks_enter(), and therefore is not considered to have been leaked in _dbus_check_fdleaks_leave(). Resolves: https://gitlab.freedesktop.org/dbus/dbus/-/issues/540 Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 7cbb7b75dd2803fcb0c6edb18d5c43e4eaeee704)
-
Simon McVittie (Collabora) authored
Debian GNU/Hurd has fstatfs() but not PROC_SUPER_MAGIC. Resolves: https://gitlab.freedesktop.org/dbus/dbus/-/issues/539 Bug-Debian: https://bugs.debian.org/1089641 Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 5d7b87496f3bb094b926692036ae656c31efdd8e)
-
Simon McVittie (Collabora) authored
If we set the countdown to simulating a failed allocation to _DBUS_INT_MAX, then it will decrement every time we allocate memory, eventually reaching 0 and triggering a simulated malloc failure. In practice this does not happen during unit testing, because all of our tests are (intentionally!) short enough that this can't happen, but it can happen if a build of dbus with embedded tests enabled is used for the "real" dbus-daemon or a "real" D-Bus service, either during debugging or unintentionally, as noted on dbus/dbus!493. We cannot simply special-case `_DBUS_INT_MAX` to never be decremented, because _dbus_test_oom_handling() relies on the counter being decremented even while we are not simulating malloc failure, as a way to count the number of allocations as an upper bound for how long to set the countdown during subsequent test runs. Instead, reserve all negative numbers to represent the absence of malloc failure simulation, while still being able to count allocations by comparing two different negative numbers. Resolves: https://gitlab.freedesktop.org/dbus/dbus/-/issues/535 Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 0735c401a7b3c9e56096fcde8139e773067302bd)
-
Simon McVittie (Collabora) authored
Previously, the CMake build enabled tests by default, and enabled both modular and intrusive (embedded) tests with a single option. This is a really bad idea if anyone is using CMake-built binaries in production. DBUS_BUILD_TESTS now enables only the modular tests, which are safe to enable in production builds. A new DBUS_ENABLE_INTRUSIVE_TESTS option enables the intrusive test instrumentation. To preserve existing test coverage, explicitly enable the intrusive tests in most CMake-based Gitlab-CI jobs (Debian native, openSUSE native, Windows). In jobs that have a mirrored pair of production/debug builds (openSUSE and Debian mingw32/mingw64 cmake), instead we leave the production build as-is and only build full test coverage in the debug build. Co-authored-by:
Philip Withnall <philip@tecnocode.co.uk> Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 41c7570e1ea803e9635d9bcabba5fc221c94e7e6)
-
Simon McVittie (Collabora) authored
This hopefully helps to get across the point that enabling these tests adds instrumentation to libdbus and dbus-daemon, with a potentially significant impact on code size, performance and security. To avoid a huge diffstat which would be difficult to review, the cpp macro that is checked by most of the C code is still DBUS_ENABLE_EMBEDDED_TESTS, which is defined or undefined under exactly the same conditions as the new DBUS_ENABLE_INTRUSIVE_TESTS. Resolves: https://gitlab.freedesktop.org/dbus/dbus/-/issues/537 Co-authored-by:
Philip Withnall <philip@tecnocode.co.uk> Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 9c5b5838f5ff667225a913f97006816e3e401d55)
-
The DBus1_xxx variables defined in DBusConfig.cmake for Windows builds are currently hard-coded values and independent of those of the underlying cmake target. To avoid this, these values are retrieved from the corresponding cmake target. In addition, the cmake allows the construction of the resulting relocatable runtime paths. (cherry picked from commit 29c2e9141a0c0dd850c89b5196fba9fa8eb66d89)
-
Simon McVittie (Collabora) authored
This function is already inside `#ifdef DBUS_ENABLE_EMBEDDED_TESTS` and doesn't need a second layer of the same guard. Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 6e61173d6462b2793c213aa13d4392f232d1c6ec)
-
- Dec 09, 2024
-
-
Simon McVittie (Collabora) authored
Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit 7dc12d17c8c6908205e2f220e579c88c0068d56e)
-
Simon McVittie (Collabora) authored
Commit 4ebb275a disabled deprecation warnings in the Autotools build system, which we no longer have. Future stable-branches will want to disable deprecation warnings in Meson instead. Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit f651834427a603e6ac81758e5a300dca3cbe077a)
-
Simon McVittie (Collabora) authored
`meson dist` requires the version you intend to release to have been committed already, and does not create any generated files in the `${srcdir}` that are intended to be committed to git. Signed-off-by:
Simon McVittie <smcv@collabora.com> (cherry picked from commit b97b083f9a0600c51f702cfd452755e8c0625de2)
-