Skip to content

networks: Try config changes for primary network connection.

Sunil Mohan Adapa requested to merge sunilmohan/freedombox:network-changes into master

This is continuation of remaining changes in !1968 (closed) done by @fioddor-guest.

Solves: #1962

Usage: Only for primary network connection, provide an alternative 'Try' button (and its related widgets). This applies the configuration changes for a limited time and reverts them afterwards. During that time the user must check the connection. Whenever she feels confident with them she must press the 'Apply' button to apply them permanently.

  • Add countdown while trying connection changes.

  • User specifies timeout. Timeout is now specified by the user. Instead of 2 buttons now a single button either applies the changes if timeout is 0, otherwise it tries (applies and auto-reverts).

  • Log invalid reconfiguration attempts on network connections.

Internals:

  • In order to guide the user through the process, a jquery function shows and/or hides widgets at appropiate moments.
  • Encapsulate our formatting of connection settings to a subfunction for reuse by both:
    • as form_data for form generation and
    • as settings for edit_connection() function. This causes some data to be redundant in this first implementation.

BTW, provide a 'Cancel' button for the network connection edit page.

Signed-off-by: Fioddor Superconcentrado fioddor@gmail.com

Merge request reports