coturn: Fix incorrectly passing transport argument to STUN URIs

Closes: #2362 (closed).

Passing ?transport= parameter in STUN URIs is invalid. It always uses UDP. Chrome and perhaps Firefox has recently started enforcing the correct syntax leading to failures using the Coturn server URIs we set in Janus. This also likely effects matrix-syanpse and ejabberd clients.

Links:

1. https://www.rfc-editor.org/rfc/rfc7064#section-3.1
2. https://bugs.chromium.org/p/chromium/issues/detail?id=1385735

Tests:

• Install Coturn. Observe that STUN URIs shown don't contain the 'transport' parameter.

• Install Janus and launch the meeting room. Notice that the STUN URIs in the room page don't have 'transport' parameter.

• Install ejabberd and notice that the auto-configured STUN URIs don't have 'transport' parameter.

• Install matrix-synapse and notice that the auto-configured STUN URIs don't have 'transport' parameter.

• Install ejabberd and matrix-synapse. Ensure that STUN URIs manually. They are not allowed to 'transport' parameter for the STUN URIs but must have transport parameter for TURN URIs.

Signed-off-by: Sunil Mohan Adapa sunil@medhas.org

requested review from @jvalleroy

Merged.

closed