Skip to content
Snippets Groups Projects
Damyan Ivanov's avatar
Damyan Ivanov's avatar
pushed to branch master at KGB - VCS to IRC relay / kgb
  • 4a40cd0a · releasing package kgb-bot version 1.61-1
Martina Ferrari's avatar
deleted branch fix_continuation_lines at KGB - VCS to IRC relay / kgb
Martina Ferrari's avatar
accepted merge request !10 "trim_lines: Remove prefix from continuation lines" at KGB - VCS to IRC relay / kgb
Martina Ferrari's avatar
pushed to branch master at KGB - VCS to IRC relay / kgb
Martina Ferrari's avatar
commented on merge request !10 "trim_lines: Remove prefix from continuation lines" at KGB - VCS to IRC relay / kgb

I've added a test to t/76-webhook-pipeline.t; and it works, although I'm not sure if I've adjusted it too much to the real output :)...

Damyan Ivanov's avatar
commented on merge request !10 "trim_lines: Remove prefix from continuation lines" at KGB - VCS to IRC relay / kgb

Ah, I see why the repo id is added on continuation lines, thanks to the test added by @gregoa....

Martina Ferrari's avatar
pushed to branch fix_continuation_lines at KGB - VCS to IRC relay / kgb
  • 6336b754 · t/76-webhook-pipeline.t: ensure multi-line test fails without the fix.
Martina Ferrari's avatar
pushed to branch fix_continuation_lines at KGB - VCS to IRC relay / kgb
  • 848127af · t/76-webhook-pipeline.t: ensure line is cut mid-word.
gregor herrmann's avatar
commented on merge request !10 "trim_lines: Remove prefix from continuation lines" at KGB - VCS to IRC relay / kgb

I've added a test to t/76-webhook-pipeline.t; and it works, although I'm not sure if I've adjusted it too much to the real output :)...

gregor herrmann's avatar
pushed to branch fix_continuation_lines at KGB - VCS to IRC relay / kgb
Damyan Ivanov's avatar
commented on merge request !10 "trim_lines: Remove prefix from continuation lines" at KGB - VCS to IRC relay / kgb

TLDR: please go ahead....

gregor herrmann's avatar
commented on merge request !10 "trim_lines: Remove prefix from continuation lines" at KGB - VCS to IRC relay / kgb

(And my playing around with reviewers and assignees doesn't make it better sory :))...

Martina Ferrari's avatar
commented on merge request !10 "trim_lines: Remove prefix from continuation lines" at KGB - VCS to IRC relay / kgb

@dmn Gitlab does not let me add more than one reviewer

Martina Ferrari's avatar
opened merge request !10 "trim_lines: Remove prefix from continuation lines" at KGB - VCS to IRC relay / kgb
Martina Ferrari's avatar
pushed new branch fix_continuation_lines at KGB - VCS to IRC relay / kgb
gregor herrmann's avatar
commented on merge request !9 "trickle up error messages in JSON RPC calls" at KGB - VCS to IRC relay / kgb

Merged & uploaded, thanks!

gregor herrmann's avatar
gregor herrmann's avatar
accepted merge request !9 "trickle up error messages in JSON RPC calls" at KGB - VCS to IRC relay / kgb